Fix removing one <title> renders all previous <title>s#53
Merged
birkskyum merged 3 commits intosolidjs:mainfrom Apr 15, 2025
Merged
Fix removing one <title> renders all previous <title>s#53birkskyum merged 3 commits intosolidjs:mainfrom
birkskyum merged 3 commits intosolidjs:mainfrom
Conversation
Member
|
@yume-chan , can you add at test for this? |
Member
|
Ah, excellent - if you rebase, it should run it on vitest here in the CI. |
3106613 to
ef88877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeTagmissing abreakcausing all previous<title>tags to be rendered.Repro playground: https://playground.solidjs.com/anonymous/4fa1f8e7-fcb6-4f6c-a521-daf6207fc779 (looks like
@solidjs/metadoesn't work well with HMR, so I need to refresh the preview every time I edited the source code)For whatever reason, I need to add
babel-jestpackage to rootpackage.jsonfor tests to run. I installed withpnpm@8.15.9but it still dramatically changed the lockfile, however, it didn't add any new packages.Output from
pnpm testafter cloning andpnpm i: